refactor: Move callbacks to ts 1X #28710
Merged
+223
−91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #28710 +/- ##
===========================================
+ Coverage 45.21% 45.24% +0.03%
===========================================
Files 738 738
Lines 14461 14461
Branches 2236 2236
===========================================
+ Hits 6538 6543 +5
+ Misses 7617 7613 -4
+ Partials 306 305 -1
Flags with carried forward coverage won't be shown. Click here to find out more. |
sampaiodiego
requested changes
Mar 31, 2023
KevLehman
added
the
stat: ready to merge
kodiakhq
bot
removed
the
stat: ready to merge
|
This PR currently has a merge conflict. Please resolve this and then re-add the |
gabriellsh
added a commit
that referenced
this pull request
Apr 4, 2023
…avatarEmoji * 'develop' of github.com:RocketChat/Rocket.Chat: (63 commits) fix: Messages jumping after reaction (#28770) fix: Quotes chain off by one error in quote chain limit settings (#28281) docs: update documentation (#28719) chore: /help notifying the shortcuts in multiple messages (#28765) refactor: remove Users from fibers 14 (#28780) regression(file-upload:s3): Fix missing store import (#28781) refactor: remove Users from fibers 13 (#28772) refactor: remove Users from fibers 12 (#28767) ci: revert Variable Setup changes (#28754) feat: auto link custom domain (#28501) refactor: `Rooms` model 4/4 (#28742) regression: invalid callback callAsync (#28766) refactor: remove Users from fibers 11 (#28740) refactor: Convert our Upload Code to TS (#28711) refactor: Move callbacks to ts 1X (#28710) refactor: Remove Users from fibers 10 (#28737) fix: message-parser links (#28735) refactor(client): Miscelaneous (#28732) refactor: `Rooms` model 3/4 (#28736) refactor: `Rooms` model 2X (#28715) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Further comments